Log in

No account? Create an account

Previous Entry | Next Entry

So I can't style these links with CSS because I can't figure out which, if any, HTML div they belong to (btw, you only see these links when you're logged in).

I screen-capped the problem links and the corresponding HTML:


As you can see in the screen cap, the links remain buried in the left page border because I can't figure out which, if any, div to assign padding/margins to.


( 8 comments — Leave a comment )
Sep. 27th, 2009 02:16 am (UTC)
I looked over a bunch of your pages and didn't see that. Can you give a direct link?
Sep. 27th, 2009 03:47 am (UTC)
Of course you'll have to log in to see it:


I think it's just pages that end in the "replyto=1234" variable that are affected. :)

Sep. 28th, 2009 02:04 am (UTC)
Re: Sure...
OK, I see the problem, but I can't see it on your journal, because I'd have to be logged in *as you*. Looks like you're asking about the same thing as this post, right?
Sep. 28th, 2009 10:57 pm (UTC)
Re: Sure...
The problem is the .asset-footer class is missing in the HTML
on that particular view so Carrie's code doesn't fix the problem because there's nothing to attach her CSS to. You can see those links still looks exactly the same as they did before he submitted his issue to you (on this page); you should be able to see it since I'm not him and I can see it (but I am logged in). The .asset-footer links are there without any asset-footer HTML to style them with, so they're all scrunched together on the far left hand side of the page, not where they belong.

Edit: Let me be more precise: there is asset-footer HTML there (just checked his page) but it's empty. It opens and closes without putting the .asset-footer links in between. The links are just floating around homeless, with no div in the HTML around them at all that we can style.

Edited at 2009-09-28 11:05 pm (UTC)
Sep. 29th, 2009 01:27 pm (UTC)
Re: Sure...
You're pretty much correct, but you mean the .asset-meta class, not footer, because footer is the one that contains "Entry Footer HTML". The problem happens when you reply directly to a comment and not from an EntryPage, which is what the "?replyto=xxxx" part of the URL is designating. The .asset-meta div is only part of an Entry, not a Comment, and is created in Entry::print_linkbar(). Replying directly to a comment means that Comment::print_linkbar() is called instead, which does not create the necessary enclosing div (.comment-links in this case).
Sep. 29th, 2009 07:23 pm (UTC)
Re: Sure...
Thanks for clarifying. Is it a bug or does LJ actually intend for things to work this way? Any CSS workaround you know of, or would it require a theme-layer fix? If it is a bug, can you or I submit it?

I can understand why LJ uses Entry HTML to style the "standalone comments" (comments that get their own reply page when you click "Reply" and wind up on the "replyto="1234" page), but I don't understand why LJ didn't include the HTML for the comment-linkbar - it's like they're treating the comment as an entry on those pages, yet not including the same comment-linkbar they use on all the other entry pages ...I guess I just don't get it.

Edited at 2009-09-29 07:24 pm (UTC)
Sep. 30th, 2009 04:44 pm (UTC)
Re: Sure...
I think it would have to be a layer fix, but I'll have to play around with the code to see what would have to be changed. Chances are it'll run too much of a risk of breaking the existing stylesheets.
Sep. 30th, 2009 11:17 pm (UTC)
Re: Sure...
"Chances are it'll run too much of a risk of breaking the existing stylesheets." I'm not following which will break what but I'm willing to wait if you think you might be able to come up with something...I finally get what you mean about "Replying directly to a comment means that Comment::print_linkbar() is called instead, which does not create the necessary enclosing div (.comment-links in this case)"; I keep wanting to count up divs on that view to see if by any chance a usable one for this purpose was left open...and have you seen the unstyled comment links yet on any page when you're logged in? I can see them and right-click/highlight/view source for them both on my journal and on the user's who had the same problem.
( 8 comments — Leave a comment )

Latest Month

March 2016

S2 Help Communities


Powered by LiveJournal.com
Designed by chasethestars